-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-release: add page #6095
git-release: add page #6095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the page looks great, just had one subjective suggestion.
Also, just a question, the page refers to "Git releases", but is a "Release" a native Git feature? I thought Git just has tagging, and that's utilized by GitHub/GitLab/etc for releases?
Edit:
Releases are a feature of GitHub, and are not a feature of general
git
- https://stackoverflow.com/a/38675903/6277798
It could be worth just saying "Create a release" instead of "Create a Git release" to keep it agnostic (GitHub/GitLab) but not suggest it's a Git feature.
Co-authored-by: Seth Falco <[email protected]>
You sure it was fine to merge this already? I gave an additional comment in #6095 (review) |
... It isn't that big of a deal regardless |
I'll leave that for others to decide. To me, it's a big deal as someone who learns a lot from inference. While I am on an extreme when it comes to taking things literally, it's also a more accessible as this is common in people with Autism for example.
I think it'd be better if the literal meaning was accurate, but that's just my take. |
Well if you would like me to revert the PR, I am perfectly willing to 👍 |
I'll make an entire PR instead |
common/
,linux/
, etc.)For #5137
This PR and command is cursed, it has coursed me nothing but trouble, I accidentally made a tag on tldr rather than my test repo.
I had to rebase for the first time because of a commit between a good one and another good one